Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: amilajack/eslint-plugin-compat#224 #281

Merged
merged 4 commits into from
Dec 31, 2019
Merged

fix: amilajack/eslint-plugin-compat#224 #281

merged 4 commits into from
Dec 31, 2019

Conversation

amilajack
Copy link
Owner

No description provided.

@amilajack amilajack closed this Dec 30, 2019
@amilajack amilajack reopened this Dec 30, 2019
ljharb
ljharb approved these changes Dec 30, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
@amilajack @ljharb
Update package.json
2277011 
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
@zloirock
Copy link

zloirock commented Dec 30, 2019 •
edited

It's the breaking change in the minor semver release ( 😂), you could use pinned 7.0.0, npm/node-semver@d61f828#r36469180.

@ljharb
Copy link
Collaborator

ljharb commented Dec 30, 2019

engines is purely advisory; yarn breaking on it isn’t a breaking change, it’s a bug in yarn.

@zloirock
Copy link

zloirock commented Dec 30, 2019 •
edited

Since it's not fixed for a long time in Yarn, it's positioned as a feature, not as a bug, so it's a breaking change in semver since Yarn is an important component of the NPM ecosystem and adding this field is the break of compatibility with Yarn + Node version less than specified even if it defers from the official NPM position about this field. However, I don't care where exactly is the problem.

@amilajack amilajack merged commit 72e087a into master Dec 31, 2019
amilajack added a commit that referenced this pull request Dec 31, 2019
@amilajack @ljharb
fix: #224 (#281)
67862d9 
* fix: #224

* downgrade semer to @6.3.0

* Update package.json

Co-Authored-By: Jordan Harband <ljharb@gmail.com>

Co-authored-by: Jordan Harband <ljharb@gmail.com>
@amilajack amilajack deleted the downgrade-ci-tests-node-8 branch December 31, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amilajack @zloirock @ljharb