Skip to content
This repository has been archived by the owner on Apr 18, 2022. It is now read-only.

Maintenance/update vergen #1242

Merged
merged 1 commit into from Dec 15, 2018
Merged

Maintenance/update vergen #1242

merged 1 commit into from Dec 15, 2018

Conversation

azriel91
Copy link
Member

@azriel91 azriel91 commented Dec 10, 2018 •
edited

vergen doesn't have docs on docs.rs for version 3.0.0~4 for some reason, I checked the source code for the changes.

torkleyy
torkleyy reviewed Dec 11, 2018
View reviewed changes
docs/CHANGELOG.md Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@Xaeroxe
Copy link
Member

Xaeroxe commented Dec 13, 2018

@azriel91 why is this blocked?

@azriel91
Copy link
Member Author

There is was a chain of things, in reverse order:

  1. To get a nice error message, I'd like to include the vergen error: format!("{}", e) has to work.
  2. failure couldn't build due to ambiguity in choosing a formatting implementation in backtrace. failure PR fixes the ambiguity.
  3. That PR is pending a release of backtrace for Rust 1.25 compatibility.

Hm. However since backtrace had a release (0.3.12) that no longer needs disambiguation, then this shouldn't be blocked anymore. Shall carry on!

@Xaeroxe
Copy link
Member

Xaeroxe commented Dec 13, 2018

bors try

bors bot added a commit that referenced this pull request Dec 13, 2018
@bors
Try #1242:
cd6b3cf
@bors
Copy link
Contributor

bors bot commented Dec 13, 2018

try

Build succeeded

Xaeroxe
Xaeroxe approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@Xaeroxe Xaeroxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xaeroxe
Copy link
Member

Xaeroxe commented Dec 13, 2018

r? @torkleyy

@azriel91
Copy link
Member Author

Ah I locked the backtrace crate earlier, taking that version restriction away.

torkleyy
torkleyy approved these changes Dec 15, 2018
View reviewed changes
Copy link
Member

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Xaeroxe
Copy link
Member

Xaeroxe commented Dec 15, 2018

bors r= @torkleyy, @Xaeroxe

bors bot added a commit that referenced this pull request Dec 15, 2018
@bors @azriel91
Merge #1242
658fcbf 
1242: Maintenance/update vergen r=torkleyy,Xaeroxe a=azriel91

`vergen` doesn't have docs on docs.rs for version `3.0.0~4` for some reason, I checked the source code for the changes.

Co-authored-by: Azriel Hoh <azriel91@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 15, 2018

Build succeeded

@bors bors bot merged commit 9fb5f03 into amethyst:master Dec 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Xaeroxe Xaeroxe Xaeroxe approved these changes

@torkleyy torkleyy torkleyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@azriel91 @Xaeroxe @torkleyy