chore(workflows): configure tests workflow #33
Conversation
ghost
force-pushed
the
feature/test-workflow
branch
4 times, most recently
from
43e715e
to
20663ff
Compare
This adds a workflow to run test cases against pull requests to the main and support branches.
ghost
force-pushed
the
feature/test-workflow
branch
from
20663ff
to
a86846c
Compare
ghost
marked this pull request as ready for review
ghost
linked an issue
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - run: | | ||
| git remote set-branches --add origin main |
There was a problem hiding this comment.
I've seen other one projects do this, but I have not seen this on the checkout action for main branches across other GitHub repos. Does an error occur if it's missing?
There was a problem hiding this comment.
If there was an issue with the default branch not being master before, I believe it was resolved in actions/checkout#305 and the above is no longer necessary.
Re: shallow clones actions/checkout will only grab a single commit unless you provide fetch-depth: 0 as a parameter.
There was a problem hiding this comment.
i think we added this because of commit lint and access to the history of the commits. We updated one-app to use fetch-depth:0 https://github.com/americanexpress/one-app/pull/334/files#diff-012d76a293bfa67c5d65f938b15705520eef288139f3b513cd16266e6f780a4cR14 I think that would work. We are not using this across our other repositories americanexpress/one-app#334
Both would work :-)
|
This pull request is stale because it has been open 30 days with no activity. |
|
@jgolden17 please merge this before deleting travis or you can delete Travis on this PR too. I have enabled github actions for testing |
|
This pull request is stale because it has been open 30 days with no activity. |
|
|
|
This pull request is stale because it has been open 30 days with no activity. |
|
Doop. |
|
@jgolden17 Was one of your registered email addresses removed? I guess the CLA Bot decided that meant you are not you. Well, are you? Probably easiest reopen (if you need to re-sign the CLA anyway). |
|
This pull request is stale because it has been open 30 days with no activity. |
|
closing this as it is superseeded by #50 |
This adds a workflow to run test cases again pull requests to the main branch