Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

perf(image): remove unneeded cache from node_modules #1348

Closed
wants to merge 2 commits into from

Conversation

PixnBits
Copy link
Contributor

Description

https://github.com/sindresorhus/find-cache-dir sets up a directory node_modules/.cache that the Terser webpack plugin uses. We don't need to ship these contents in our images.

Motivation and Context

As of 6.11.0 and 5.24.0 this directory is 24 and 23MB, respectively.

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Slightly less time taken pulling the image during deployments.

Copy link
Contributor

github-actions bot commented Mar 27, 2024

Size Change: 0 B

Total Size: 735 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 187 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 124 kB

compressed-size-action

@10xLaCroixDrinker 10xLaCroixDrinker deleted the perf/remove-cache-dir branch May 3, 2024 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants