chore(jest)!: add support for jest v29 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Jest v29. Jest v29 drops support for Node v12/v17, so I've updated the package.json to contain the same Node support as Jest. The only other major breaking change in Jest v29 is that the default snapshot format has changed slightly, but that only changes the stored jest snapshots slighty (see https://jestjs.io/blog/2022/08/25/jest-29). BREAKING CHANGE: Drop support for Node v12 and Node v17, as Jest v29 does not support these versions.
|
|
|
Hey, I don't have the skills to validate the "code" part of your PR, but using your branch & jest 29 "jest": "^29.0.0",
"jest-image-snapshot": "git+https://github.com/aloisklink/jest-image-snapshot.git#chore/update-jest-to-v29",works in one of our project too. Thanks for the MR! |
10xLaCroixDrinker
requested changes
Sep 14, 2022
.github/workflows/release.yml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| - name: Setup Node.js | |||
| uses: actions/setup-node@v2 | |||
| with: | |||
| node-version: 12 | |||
| node-version: 14 | |||
There was a problem hiding this comment.
Suggested change
| node-version: 14 | |
| node-version: 16 |
Let's use LTS here
There was a problem hiding this comment.
Fixed in 76edb33, let me know if you want me to rebase/squash my commits into one commit.
Node v16 is the current active LTS release of Node.JS Co-authored-by: Jamie King <hello@jamieking.me>
|
Hi folks! Any update on this PR? Would be nice to get rid of warnings when running npm install about jest-image-snapshot not being compatable with jest 29. |
10xLaCroixDrinker
approved these changes
Oct 18, 2022
|
@anescobar1991 could you review this PR? Or someone from one-amex-admins :) |
|
Is there a reason this isn't being approved? Are there any risks involved? This is blocking all projects that use this jest-image-snapshot from upgrading to jest 29 so it would be nice to sort this out sooner than later. |
anescobar1991
approved these changes
Nov 3, 2022
oneamexbot
added a commit
that referenced
this pull request
Nov 3, 2022
# [6.0.0](v5.2.0...v6.0.0) (2022-11-03) * chore(jest)!: add support for jest v29 (#309) ([79e53fc](79e53fc)), closes [#309](#309) ### BREAKING CHANGES * Drop support for Node v12 and Node v17, as Jest v29 does not support these versions. * ci(release): use Node v16 for release action Node v16 is the current active LTS release of Node.JS Co-authored-by: Jamie King <hello@jamieking.me> Co-authored-by: Jamie King <hello@jamieking.me>
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks for getting this one out the door! |
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
* chore(jest)!: add support for jest v29 Add support for Jest v29. Jest v29 drops support for Node v12/v17, so I've updated the package.json to contain the same Node support as Jest. The only other major breaking change in Jest v29 is that the default snapshot format has changed slightly, but that only changes the stored jest snapshots slighty (see https://jestjs.io/blog/2022/08/25/jest-29). BREAKING CHANGE: Drop support for Node v12 and Node v17, as Jest v29 does not support these versions. * ci(release): use Node v16 for release action Node v16 is the current active LTS release of Node.JS Co-authored-by: Jamie King <hello@jamieking.me> Co-authored-by: Jamie King <hello@jamieking.me>
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
# [6.0.0](americanexpress/jest-image-snapshot@v5.2.0...v6.0.0) (2022-11-03) * chore(jest)!: add support for jest v29 (americanexpress#309) ([79e53fc](americanexpress@79e53fc)), closes [americanexpress#309](americanexpress#309) ### BREAKING CHANGES * Drop support for Node v12 and Node v17, as Jest v29 does not support these versions. * ci(release): use Node v16 for release action Node v16 is the current active LTS release of Node.JS Co-authored-by: Jamie King <hello@jamieking.me> Co-authored-by: Jamie King <hello@jamieking.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Jest v29.
Jest v29 drops support for Node v12/v17, so I've updated the package.json to contain the same Node support as Jest.
The only other major breaking change in Jest v29 is that the default snapshot format has changed slightly, but that only changes the stored jest snapshots slighty (see https://jestjs.io/blog/2022/08/25/jest-29).
BREAKING CHANGE: Drop support for Node v12 and Node v17, as Jest v29 does not support these versions.
Motivation and Context
Resolves #308
How Has This Been Tested?
I've tried testing this branch on my own project (remark-mermaid-dataurl) using the following, and it seems to work fine.
Types of Changes
Checklist:
What is the Impact to Developers Using Jest-Image-Snapshot?
Adds support for Jest 29.
BREAKING CHANGE: Drops support for Node v12 and Node v17.