Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "legacy-peer-deps" and "force" from npm install once jest updated #3678

Closed
nbeloglazov opened this issue Oct 19, 2022 · 0 comments · Fixed by #3826
Closed

Remove "legacy-peer-deps" and "force" from npm install once jest updated #3678

nbeloglazov opened this issue Oct 19, 2022 · 0 comments · Fixed by #3826
Assignees
@nbeloglazov
Labels
infrastructure Setting up tooling, deployment, cloud, etc

Comments

@nbeloglazov
Copy link
Contributor

In browser tests at the moment we are using version of jest-image-snapshot that doesn't support jest 29 while we are using jest 29. It breaks normal npm install as it detects requirement mismatch. To workaround we suppress that error by adding npm install --force or legacy-peer-deps in .npmrc. This is temporary workaround until americanexpress/jest-image-snapshot#309 is submitted and new version jest-image-snapshot is released.
@nbeloglazov nbeloglazov added the infrastructure Setting up tooling, deployment, cloud, etc label Oct 19, 2022
@nbeloglazov nbeloglazov self-assigned this Oct 19, 2022
@nbeloglazov nbeloglazov mentioned this issue Oct 19, 2022
Merged
3 tasks
nbeloglazov added a commit that referenced this issue Oct 20, 2022
@nbeloglazov
Add option to ignore npm version mismatch (#3679)
df4c4f4 
See #3678 for more details. This PR adds .npmrc with option that ignores version mismatch. This is required for rennovate bot to be happy. Currently it fails to update some npm dependencies because it trips over that warning.
@nbeloglazov nbeloglazov mentioned this issue Nov 17, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbeloglazov nbeloglazov

Labels
infrastructure Setting up tooling, deployment, cloud, etc
Projects
CiviForm Project Roadmap & Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove --force from npm install civiform/civiform
1 participant
@nbeloglazov