Add ALL target for ament_generate_version_header target. (backport #526) #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
This is necessary when using ament_generate_version_header() with a target that is an INTERFACE library, so that it actually gets built. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 1388e09)
|
CI:
|
|
Holding off on this one for Jazzy patch release 1. |
|
We'll hold off on merging this until after Jazzy is released, and will target this for Patch release 1. |
ahcorde
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary when using ament_generate_version_header() with a target that is an INTERFACE library, so that it actually gets built.
This should fix #525
This is an automatic backport of pull request #526 done by Mergify.