Do not export exec_depends in ament_auto_package #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathias Lüdtke <mathias.luedtke@pal-robotics.com>
While I agree that this is somewhat suspicious, I'm also wary that changing this has the potential to break downstream packages that are currently depending on this. Can you give an example of how this breaks dependent packages? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior (implemented 9 year ago) treats exec_depends (former run_depends) as build_export_depends, which is not correct and in some cases can even break the build of dependent packages.
The combination of
build_depend+exec_depend(but nobuild_export_depend) is a common pattern for executables (which do not need to export), whereas libraries (which need to export) often use the blanketdepend.