Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ament_cmake_auto_gtest #257

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Add ament_cmake_auto_gtest #257

wants to merge 1 commit into from

Conversation

cho3
Copy link

@cho3 cho3 commented May 16, 2020

I use ament_cmake_auto a lot and ament_cmake_gtest a lot, so I find myself writing a lot of stuff I don't have to for the libraries and executables.

Here is a copy/paste Frankenstein solution between ament_auto_add_executable and ament_add_gtest to start the conversation.

I have tested this locally on a very limited use case.

Signed-off-by: Christopher Ho christopherj.ho@gmail.com

Signed-off-by: Christopher Ho <christopherj.ho@gmail.com>
@hidmic hidmic requested a review from mjcarroll May 26, 2020 13:59
@sloretz
Copy link
Contributor

sloretz commented Jun 25, 2020

@mjcarroll friendly ping :)

@ivanpauno
Copy link
Contributor

@mjcarroll friendly ping

@KeisukeShima
Copy link

@cho3 Hi,
Thank you for your wonderful pull request. I've seen the changes, but it looks like there's a problem with how to use cmake_parse_arguments.

The documentation is here.
https://cmake.org/cmake/help/v3.6/command/cmake_parse_arguments.html

My suggestions are:

  cmake_parse_arguments(ARG
    "WIN32;MACOSX_BUNDLE;EXCLUDE_FROM_ALL;NO_TARGET_LINK_LIBRARIES;SKIP_LINKING_MAIN_LIBRARIES;SKIP_TEST"
    "RUNNER;TIMEOUT;WORKING_DIRECTORY;DIRECTORY"
    "APPEND_ENV;APPEND_LIBRARY_DIRS;ENV"
    ${ARGN})

@audrow audrow changed the base branch from master to rolling June 28, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants