Add 1.1 binary reader support for length-prefixed Lists & S-Expressions #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
nirosys
commented
May 15, 2024
| /// If it succeeds, marks the `DataSource` as ready to advance by the 'n' bytes | ||
| /// that were consumed. | ||
| /// If it does not succeed, the `DataSource` remains unchanged. | ||
| pub(crate) fn try_parse_next<F: Fn(Self) -> IonResult<Option<LazyRawBinaryValue_1_1<'a>>>>( |
There was a problem hiding this comment.
This method was actually broken with the removal of bytes_to_skip, but luckily nothing else used it. I noticed as I was working through adding similar bytes_to_skip functionality for sequences.
nirosys
force-pushed
the
rgiliam/1_1_binary_reader_prefixed_sequences
branch
from
8c59dac
to
7b4e3c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #664
Description of changes:
This PR adds length-prefixed Lists and S-Expressions to the 1.1 raw binary reader.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.