Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.16.2 #1401

Merged
merged 2 commits into from
Apr 25, 2022
Merged

v0.16.2 #1401

merged 2 commits into from
Apr 25, 2022

Conversation

ParthivNaresh
Copy link
Collaborator

@ParthivNaresh ParthivNaresh commented Apr 25, 2022 •
edited

v0.16.2 Apr 25, 2022

@ParthivNaresh ParthivNaresh self-assigned this Apr 25, 2022
bchen1116
bchen1116 reviewed Apr 25, 2022
View reviewed changes
docs/source/release_notes.rst
@@ -3,15 +3,21 @@
Release Notes
-------------

Future Release
==============
.. Future Release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we always have the .. and space here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! It's necessary as part of restructured text syntax for commenting: https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#comments

@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited

Codecov Report

Merging #1401 (04610e2) into main (0f699ab) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1401   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          97       97           
  Lines       10412    10412           
=======================================
  Hits        10408    10408           
  Misses          4        4
Impacted Files Coverage Δ
woodwork/tests/test_version.py 100.00% <100.00%> (ø)
woodwork/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f699ab...04610e2. Read the comment docs.

jeremyliweishih
jeremyliweishih approved these changes Apr 25, 2022
View reviewed changes
Copy link

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need to look at the formatting for release notes but send it otherwise!

bchen1116
bchen1116 approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!

@ParthivNaresh ParthivNaresh merged commit 83115ba into main Apr 25, 2022
@gsheni gsheni deleted the release_v0.16.2 branch July 18, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes

@gsheni gsheni gsheni approved these changes

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@bchen1116 bchen1116 bchen1116 approved these changes

@Cmancuso Cmancuso Awaiting requested review from Cmancuso

@jeff-hernandez jeff-hernandez Awaiting requested review from jeff-hernandez

@rwedge rwedge Awaiting requested review from rwedge

Assignees

@ParthivNaresh ParthivNaresh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ParthivNaresh @thehomebrewnerd @gsheni @jeremyliweishih @bchen1116