Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Latest Dependency Updates #1530

Closed
wants to merge 1 commit into from
Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 9, 2020

This is an auto-generated PR with dependency updates. Please do not delete the dep-update branch because it's needed by the auto-dependency bot.

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #1530 (f6e2225) into main (70226e1) will decrease coverage by 8.5%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #1530     +/-   ##
========================================
- Coverage   100.0%   91.6%   -8.4%     
========================================
  Files         230     230             
  Lines       15824   15824             
========================================
- Hits        15816   14479   -1337     
- Misses          8    1345   +1337     
Impacted Files Coverage Δ
...alml/tests/component_tests/test_lgbm_classifier.py 5.0% <0.0%> (-95.0%) ⬇️
...valml/tests/component_tests/test_target_encoder.py 8.6% <0.0%> (-91.4%) ⬇️
evalml/automl/pipeline_search_plots.py 14.6% <0.0%> (-85.4%) ⬇️
...ml/tests/component_tests/test_xgboost_regressor.py 16.0% <0.0%> (-84.0%) ⬇️
...l/tests/component_tests/test_xgboost_classifier.py 16.4% <0.0%> (-83.6%) ⬇️
...l/tests/component_tests/test_catboost_regressor.py 19.4% <0.0%> (-80.6%) ⬇️
.../tests/component_tests/test_catboost_classifier.py 19.4% <0.0%> (-80.6%) ⬇️
...l/tests/automl_tests/test_pipeline_search_plots.py 25.6% <0.0%> (-74.4%) ⬇️
evalml/tests/pipeline_tests/test_graphs.py 38.7% <0.0%> (-61.3%) ⬇️
...ents/estimators/classifiers/catboost_classifier.py 50.0% <0.0%> (-50.0%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70226e1...f6e2225. Read the comment docs.

@angela97lin
Copy link
Contributor

Odd, could be related to XGBoost package update? Just realized that this started happening on all PRs

@dsherry
Copy link
Contributor

dsherry commented Dec 9, 2020

This is weird!

Observations

  • PR is updating both plotly and xgboost version
  • Windows unit tests pass
  • Linux "minimum deps" tests pass
  • Linux full deps test pass with cryptic worker crash (probably masking the real error)
  • Build docs job fails with cryptic build error: "Inconsistency detected by ld.so: dl-version.c: 205: _dl_check_map_versions: Assertion `needed != NULL' failed!"

I have a sneaking suspicion this is related to the fix I merged for shap recently, #1490. That PR makes it so we're installing numba (a dependency for new numpy version) via conda instead of pip. I wonder if the xgboost update is interacting with this somehow on linux. My hunch is that xgboost is the culprit and not plotly but I could be wrong, needs confirmation.

Things to try next

  • ASAP: merge a PR where we cap the plotly/xgboost versions, to unblock other PRs (I've got this, Set max value for plotly and xgboost versions #1532)
  • Get a version of this PR up where we only pin xgboost and update the plotly version, and see if we can merge that. (Or vice versa)
  • Look into the xgboost and plotly changelogs and see if there are any clues there
  • Try to ssh into circleci box and rerun the test job without multiple workers, perhaps that unmasks the actual error message
  • Look at the output of pip freeze on the circleci box
  • Try to repro the linux test failure locally
  • If we can't find a fix this week, we can always put a max value on the xgboost version, file a future issue and close this PR.

@dsherry
Copy link
Contributor

dsherry commented Dec 9, 2020

I just merged #1532 to cap the versions, so closing this. But @bchen1116 has said he'll take a look! :)

@dsherry dsherry closed this Dec 9, 2020
@hcho3
Copy link

hcho3 commented Dec 9, 2020

@dsherry @bchen1116 Hello, XGBoost dev here. The Python wheel for XGBoost 1.3.0 had a critical bug that rendered it unusable on CentOS and Debian platforms. I submitted dmlc/xgboost#6482 to fix the bug. Once dmlc/xgboost#6482 is approved and merged, we will release 1.3.0.post0 version to PyPI.

@bchen1116
Copy link
Contributor

@hcho3 Thanks so much for the update!

@freddyaboulton freddyaboulton deleted the dep-update-70226e1 branch May 13, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants