Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Sphinx 3.4 #196

Closed
wants to merge 1 commit into from
Closed

Allow Sphinx 3.4 #196

wants to merge 1 commit into from

Conversation

altendky
Copy link
Owner

@altendky altendky commented Dec 28, 2020

Draft for:

  • A fix in the case that this is not deemed a Sphinx bug

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #196 (641c596) into master (6fdcc10) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #196   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         1500      1500           
  Branches        77        77           
=========================================
  Hits          1500      1500           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fdcc10...641c596. Read the comment docs.

@altendky
Copy link
Owner Author

Looks to be an unintended change in Sphinx behavior (sphinx-doc/sphinx#8602 (comment)) but I'll keep this open for now.

@altendky altendky marked this pull request as draft December 28, 2020 15:55
@altendky
Copy link
Owner Author

Nope, Sphinx put in a fix.

@altendky altendky closed this Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant