Track republishing of Pages in the new Republishing UI #9042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll create one of these whenever a user republishes content via the admin interface to keep track of why and how often this action is being performed, as well as the reason why. This will help us understand how useful this part of the admin interface is.
This adds a textarea to the Page republishing confirmation page to capture the reason for republishing a page. This is a mandatory field. Submitting the form now creates a RepublishingEvent containing: - the action being performed: e.g. that a page has been scheduled for republishing, re-using the original flash message for this - the reason why the document was republished to help us understand how people are using this functionality - the user who performed the republishing I've opted not to add a cucumber feature test for the validation error as although I've seen one or two validation error tests in cucumber tests, I feel this is well-tested enough in the functional test, and don't want to double the number of tests as we'd need to add one for each type of content item anyway.
brucebolt
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
Context
Trello card
Now that we've added a new UI for republishing content to replace the running of various rake tasks, we want to know how often it's being used and why.
Changes in this PR
This PR adds a new
RepublishingEventmodel to Whitehall to keep track of an action being performed (i.e. republishing a thing), a user-entered reason why, and the user who performed the action. The (mandatory) reason for republishing is captured in a newly-added textarea in the Republishing UI for republishing specific Pages, but will shortly be added to the other content types in the interface.Screenshot (including validation error)