Remove GenericEditionPresenter
#9041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of moving the rendering of content out of Whitehall, we have introduced a Publishing API presenter for each type of document. We therefore no longer need the `GenericEditionPresenter` that was being used to send placeholder content items to Publishing API.
Otherwise lots of test failures like: ``` Error: Admin::GenericEditionsController::TranslationTest#test_show_omits_the_link_to_edit_an_existing_translation_unless_the_edition_is_editable: NoMethodError: undefined method `lead_organisations' for #<GenericEdition id: 163, ```
|
Never mind - thought this might be a quick win but it's going to be a rabbit hole. Lots of errors as follows: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-hashing #8093 to see whether the tests are still reliant on the generic edition presenter. Hoping to add more info to https://trello.com/c/9n7FoudZ/32-whitehall-has-a-genericeditionpresenter.
As part of moving the rendering of content out of Whitehall, we have introduced a Publishing API presenter for each type of document.
We therefore no longer need the
GenericEditionPresenterthat was being used to send placeholder content items to Publishing API.Follow these steps if you are doing a Rails upgrade.