Fix bug with social media accounts on new editions #9038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
fix-ww-org-social
branch
from
6a62a4b
to
d449d09
Compare
When an Editionable Worldwide Organisation was being editioned (i.e. a new draft created), the social media accounts were lost, but only for worldwide organisations that had no translations. This was because we were using the `build` method to create the record but never saving it. For the worldwide organisations with translations, the call to `update` saved the record, but this never happened for those without translations. The tests did not catch this as `create_draft` returns the unsaved object. Therefore reloading the object in the test to ensure we get the persisted object from the database.
brucebolt
force-pushed
the
fix-ww-org-social
branch
from
d449d09
to
7f3725b
Compare
Gweaton
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an Editionable Worldwide Organisation was being editioned (i.e. a new draft created), the social media accounts were lost, but only for worldwide organisations that had no translations.
This was because we were using the
buildmethod to create the record but never saving it.For the worldwide organisations with translations, the call to
updatesaved the record, but this never happened for those without translations.The tests did not catch this as
create_draftreturns the unsaved object. Therefore reloading the object in the test to ensure we get the persisted object from the database.Trello card