Test. Override email rake #9005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccapearce
force-pushed
the
why-are-my-tests-failing
branch
from
665009d
to
0bd37e5
Compare
You were stubbing the the taxon content item on line 10 with stub_publishing_api_has_item(content_id: work_taxon_content_id, title: work_taxon_parent["title"]) But then on line 22, you were passinging in the root_taxon_content_id. So when the task fetched the taxon with the root taxon content id, it wasn't stubbed, so there would have been that webmock error. The cryptic JSON::ParserError: unexpected token at '' error is raised by the to_h method, when it tries to parse a JSON response from publishing API. Fix 2 The document_collection is cached. So if you've updated it during the test (which you have) you need to fetch it again.
hannako
force-pushed
the
why-are-my-tests-failing
branch
from
f0660f3
to
5c1da41
Compare
hannako
force-pushed
the
why-are-my-tests-failing
branch
from
5c1da41
to
faf95b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.