Add a description to the past prime ministers page #8523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was pointed out that the past prime ministers page was missing a description. This means that only the title of the page shows up in the search results. The description has been hard-coded to match the page title, though this content should probably be moved to a locale file or be editable by publishers in the UI. The content for the description also needs to be checked by a content designer.
leenagupte
force-pushed
the
add-past-prime-ministers-description
branch
from
bf00705
to
63e2001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was pointed out that the past prime ministers page was missing a description. This means that only the title of the page shows up in the search results.
The description has been hard-coded to match the page title, though this content should probably be moved to a locale file or be editable by publishers in the UI.
The content for the description also needs to be checked by a content designer.
Follow these steps if you are doing a Rails upgrade.