[spike] Increase top-k size to 40 by default for relevance queries #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queries will by default fetch 40 documents from Elasticsearch, or the K documents specifies by the `k` query parameter (max: 40). The reranker will re-rank K documents, and return only the top-k specified through the `count` parameter. This will put greater load on the Elasticsearch cluster but should improve search quality for relevance queries.
sihugh
reviewed
Mar 11, 2022
| @@ -94,7 +94,7 @@ def rerank(es_response, search_params) | |||
|
|
|||
| return { reranked: false, es_response: es_response } if reranked.nil? | |||
|
|
|||
| es_response["hits"]["hits"] = reranked | |||
| es_response["hits"]["hits"] = reranked.first(search_params.count) | |||
There was a problem hiding this comment.
If k is 2 * count then might we need to flipflop between first(count) and last(count) depending if start % k is 0 or count? We could end up reranking results out of existence otherwise?
There was a problem hiding this comment.
We could introduce some jitter here to give some results a chance. Maybe @hannako has some ideas on how we might occassionally swap downranked results into the top-k. 🤔
We could ocassionally return the bottom-k to some users, might be fairer to spread it out a bit among users, since we can assume most of the time the top-k is going to be better.
|
We're no longer using this fancy stuff 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries will by default fetch 40 documents from Elasticsearch,
or the K documents specifies by the
kquery parameter (max: 40).The reranker will re-rank K documents, and return only the top-k
specified through the
countparameter.This will put greater load on the Elasticsearch cluster but should
improve search quality for relevance queries.