Update rubocop requirement from ~> 1.7.0 to ~> 1.10.0 #127
Conversation
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
dependabot-preview
bot
added
the
dependencies
kevindew
force-pushed
the
dependabot/bundler/rubocop-gte-1.7-and-lt-1.11
branch
2 times, most recently
from
ac7cf56
to
80f9e48
Compare
|
This seems like an ok change to go in. The new rules added don't look particularly problematic or divisive. If it turns out some are we're already planning to do a pre-release of the next version where this should be revealed. The new rules are:
|
kevindew
changed the title
Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.7.0...v1.10.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: Kevin Dew <kevindew@me.com>
kevindew
force-pushed
the
dependabot/bundler/rubocop-gte-1.7-and-lt-1.11
branch
from
80f9e48
to
c9b5038
Compare
There was a problem hiding this comment.
Thanks for listing them all out - made it much easier to review 🎖️. I think these are good as well, particularly the ones that emulate v3 warnings.
The only one I (personally) dislike is Lint/SymbolConversion, as it's not clear why :'string' is so much better / clearer than 'string'.to_sym. I'd say the latter is more explicit, and thus easier to read. But I don't think it's a major issue.
Oh yeah - that one hadn't really caught my attention. Yeah I don't think it'll be a big concern, I find myself somewhat agreeing with your point but also feeling like using |
Updates the requirements on rubocop to permit the latest version.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
... (truncated)
Commits
9e8a5eeCut 1.1053d8723Update Changelogdcd8b7dUpgrade rubocop-rspec708eb90Fix RSpec/StubbedMock offensesfcb3a94Improve documentation for Style/EvalWithLocation cop6cdce3bAddIgnoreModulesconfiguration toStyle/ConstantVisibility07cd64c[Fix #9349] Fix a false positive forLint/MultipleComparison7e89008[Fix #9513] Fix an incorrect auto-correct forStyle/HashConversion2d3e1bc[Fix #9403] Add autocorrect forStyle/EvalWithLocationb2aa853Fix a false negative forLint/ElseLayoutDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: