Merge pull request #125 from alphagov/disable-problem-rules

Disable recently problematic rules
alphagov · Feb 16, 2021 · 5a9eace · 5a9eace
2 parents ff18f90 + 7437126
commit 5a9eace
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@
 - Downgrade local Ruby version to `2.6.6` to capture lowest supported
   Ruby version
 - Fix namespace change of `Capybara/FeatureMethods`
+- Disable `Naming/VariableNumbers`
 
 # 3.17.2
 

diff --git a/config/naming.yml b/config/naming.yml
@@ -19,3 +19,10 @@ Naming/AccessorMethodName:
 # repos, which would require manual intervention.
 Naming/PredicateName:
   Enabled: false
+
+# This rule can cause readability issues when applied (for example
+# `born_on_or_before_6_april_1935` becomes `born_on_or_before_6april1935`)
+# and would require lots of amends to apply either `normalcase`
+# or `snake_case` to projects. It is not auto-correctable.
+Naming/VariableNumber:
+  Enabled: false
diff --git a/config/rspec.yml b/config/rspec.yml
@@ -10,6 +10,11 @@ inherit_from:
 RSpec/ExampleLength:
   Enabled: false
 
+# We should avoid cops that are based on heuristics, since
+# it's not clear what action to take to fix an issue.
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 # We have common cases, such as rake tasks, where we do not
 # use a class to the describe the test.
 RSpec/DescribeClass: