Update code for version 3.4.1 onwards of pyproj dependency #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 3.4.1 of pyproj changed the ESPG codes to be upper case, which means that our tests now fail (pyproj4/pyproj#1162). This change updates our code to also use upper case codes, and bumps the minimum version of pyproj to ensure that we're always using a version which also uses the upper case codes.
quis
approved these changes
Dec 15, 2022
|
We should probably add a version bump to this PR and check that it can be installed into our other apps without causing issues there (it probably shouldn't 🤞) |
|
I've bumped the version and tested it out - we'll need to rebuild the broadcast area library in admin once admin is using this version of utils |
|
Cool - thanks for investigating. Let's do this as a major (breaking) version bump then, I think. If you update that and add a changelog entry/etc I think it's good to go in :) |
Bump pyproj to be version 3.4.1 or greater. This changes the ESPG codes to be upper case, which affects the how `Polygons` class transforms data.
|
This is now version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.4.1 of pyproj changed the ESPG codes to be upper case, which means that our tests now fail (pyproj4/pyproj#1162).
This change updates our code to also use upper case codes, and bumps the minimum version of pyproj to ensure that we're always using a version which also uses the upper case codes.