Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust metadata spacing in image card #390

Merged
merged 1 commit into from Jun 26, 2018
Merged

Adjust metadata spacing in image card #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/assets/stylesheets/govuk_publishing_components/components/_image-card.scss
View file
Open in desktop
Expand Up @@ -59,6 +59,7 @@
}

.gem-c-image-card__context,
.gem-c-image-card__metadata,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? I can't see the difference between having this here and not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main link has a pseudo element that covers the whole component in order to make the image clickable without duplicating the link. Any other elements that should be not underneath this pseudo element (particularly other links) have a higher z-index.

.gem-c-image-card__description {
position: relative;
z-index: 2;
Expand All @@ -67,11 +68,17 @@
.gem-c-image-card__context,
.gem-c-image-card__metadata {
@include core-14;
margin-bottom: $gutter-one-quarter;
color: $grey-1;

@include media(tablet) {
margin-bottom: 0;
}
}

.gem-c-image-card__description {
padding-top: $gutter-one-quarter;
word-wrap: break-word;
}

.gem-c-image-card__list {
Expand Down