New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subscription links component #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to copy over the email and feed icons as well.
} | ||
|
||
.gem-c-subscription-links__link--feed { | ||
background-image: image-url("feed-icon-black.png"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to copy over this icon into the gem as well (same applies to the email icon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, can't believe I missed that. Actually on second thought I can, worth noting... I think I missed this because I was moving the gem while using the component guide in government-frontend for reference, so it was still picking up the images from government-frontend. Fixed.
display: inline-block; | ||
margin-left: $gutter-half / 2; | ||
margin-right: $gutter-half / 2; | ||
margin-bottom: $gutter / 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this just $gutter-half
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's weird. Have changed.
7a294e0
to
d607586
Compare
d607586
to
ef17ad4
Compare
ef17ad4
to
91cf33e
Compare
91cf33e
to
fee41a0
Compare
fee41a0
to
639a0d9
Compare
Moving from government-frontend to the gem. A separate PR will be raised to remove it from government-frontend. No changes to the component other than changing the CSS namespace from app-c to gem-c.
Trello cards: