Fix single page notification button data attributes for tracking #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danacotoran
force-pushed
the
fix-tracking-attributes
branch
from
ca7216f
to
f546f9b
Compare
danacotoran
force-pushed
the
fix-tracking-attributes
branch
from
f546f9b
to
8a648c1
Compare
danacotoran
force-pushed
the
fix-tracking-attributes
branch
from
8a648c1
to
f209d3e
Compare
|
Re-drafted this while I investigate another potential tracking issue which could go in the same PR |
danacotoran
force-pushed
the
fix-tracking-attributes
branch
from
f209d3e
to
1ce4bab
Compare
danacotoran
changed the title
andysellick
reviewed
Nov 24, 2021
...assets/javascripts/govuk_publishing_components/components/single-page-notification-button.js
Outdated
Show resolved
Hide resolved
...assets/javascripts/govuk_publishing_components/components/single-page-notification-button.js
Outdated
Show resolved
Hide resolved
danacotoran
changed the title
danacotoran
force-pushed
the
fix-tracking-attributes
branch
from
5b7dece
to
18a344e
Compare
andysellick
reviewed
Nov 25, 2021
andysellick
approved these changes
Nov 25, 2021
The data attributes for tracking are not named correctly. data-label should be data-track-label, data-action should be data-track-action, data-category should be data-track-category.
Apply the data-module="gem-track-click" for the single page notification button to a component wrapper div. The reason behind applying this to a wrapper and not to the form is that the form gets swapped out with the form returned from the personalisation endpoint, so the track click module would have to be re-started on the new, updated form. Applying the track-click attribute to a wrapper instead means we don't have to re-start the gem-track-click module for the updated form.
danacotoran
force-pushed
the
fix-tracking-attributes
branch
from
414c76c
to
2dc71b5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
data-labelattribute should bedata-track-label,data-actionshould bedata-track-action,data-categoryshould bedata-track-category.data-module=gem-track-clickattribute to a wrapper div instead of the form itself. The reason for this is thatthe form gets dynamically swapped out with the form returned from the personalisation endpoint. If
data-module=gem-track-clickwas applied to the form, then in order for click tracking to fire correctly after the JS update has occurred, the track click module would have to be re-started on the updated form, which is not ideal.This is a workaround which can be credited to @andysellick