Add [Withdrawn] to the og:title tag of withdrawn content #2066
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
reviewed
May 14, 2021
app/views/govuk_publishing_components/components/_machine_readable_metadata.html.erb
Outdated
Show resolved
Hide resolved
benjamineskola
force-pushed
the
prefix-title-withdrawn
branch
from
f53263e to
21ad535
Compare
thomasleese
reviewed
May 14, 2021
benjamineskola
force-pushed
the
prefix-title-withdrawn
branch
from
21ad535 to
3f2c306
Compare
thomasleese
approved these changes
May 17, 2021
benjamineskola
force-pushed
the
prefix-title-withdrawn
branch
from
3f2c306 to
730ef96
Compare
benjamineskola
force-pushed
the
prefix-title-withdrawn
branch
from
730ef96 to
89c35bc
Compare
benjamineskola
force-pushed
the
prefix-title-withdrawn
branch
from
89c35bc to
7d9e2bd
Compare
benjamineskola
force-pushed
the
prefix-title-withdrawn
branch
from
7d9e2bd to
b61784c
Compare
benjamineskola
force-pushed
the
prefix-title-withdrawn
branch
from
b61784c to
d8803b8
Compare
benjamineskola
force-pushed
the
prefix-title-withdrawn
branch
from
d8803b8 to
c327066
Compare
benjamineskola
force-pushed
the
prefix-title-withdrawn
branch
from
c327066 to
ed3cbef
Compare
benjamineskola
force-pushed
the
prefix-title-withdrawn
branch
from
ed3cbef to
4ee04ee
Compare
benjamineskola
force-pushed
the
prefix-title-withdrawn
branch
from
4ee04ee to
b965c72
Compare
benjamineskola
force-pushed
the
prefix-title-withdrawn
branch
2 times, most recently
from
7c0b206 to
36e118e
Compare
benjamineskola
force-pushed
the
prefix-title-withdrawn
branch
from
36e118e to
a576f4a
Compare
benjamineskola
added a commit
that referenced
this pull request
May 24, 2021
* Add `[Withdrawn]` to the beginning of the `og:title` meta tag for withdrawn pages ([PR #2066](#2066)) * Fix accordion anchor link navigation bug ([PR #2087](#2087)) * Remove jQuery from the feedback component ([PR #2062](#2062)) * Remove `display: none` rules from component print stylesheets, and use the `govuk-!-display-none-print` class instead. ([PR #1561](#1561)) * Fix IE11 `initCustomEvent` error ([PR #2079](#2079))
Merged
benjamineskola
added a commit
that referenced
this pull request
May 24, 2021
* Add `[Withdrawn]` to the beginning of the `og:title` meta tag for withdrawn pages ([PR #2066](#2066)) * Fix accordion anchor link navigation bug ([PR #2087](#2087)) * Remove jQuery from the feedback component ([PR #2062](#2062)) * Remove `display: none` rules from component print stylesheets, and use the `govuk-!-display-none-print` class instead. ([PR #1561](#1561)) * Fix IE11 `initCustomEvent` error ([PR #2079](#2079))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
For content that has been withdrawn, prefixes the
og:titletag with '[Withdrawn]'.https://trello.com/c/7OxshPDC/2498-2-add-withdrawn-to-ogtitle-tag
Why
Visual Changes