Adjust metadata spacing in image card #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,6 +59,7 @@ | |||
| } | |||
|
|
|||
| .gem-c-image-card__context, | |||
| .gem-c-image-card__metadata, | |||
There was a problem hiding this comment.
What does this do? I can't see the difference between having this here and not.
There was a problem hiding this comment.
The main link has a pseudo element that covers the whole component in order to make the image clickable without duplicating the link. Any other elements that should be not underneath this pseudo element (particularly other links) have a higher z-index.
vanitabarrett
approved these changes
Jun 26, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change only applies on mobile.
Before:
After:
Trello card: https://trello.com/c/QIV37tWx/218-font-size-spacing-of-featured-news-stories-on-mobile
Component guide for this PR:
https://govuk-publishing-compon-pr-390.herokuapp.com/component-guide/image_card