Add subscription links component #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabarrett
suggested changes
May 1, 2018
| } | ||
|
|
||
| .gem-c-subscription-links__link--feed { | ||
| background-image: image-url("feed-icon-black.png"); |
There was a problem hiding this comment.
We need to copy over this icon into the gem as well (same applies to the email icon)
There was a problem hiding this comment.
Ah, can't believe I missed that. Actually on second thought I can, worth noting... I think I missed this because I was moving the gem while using the component guide in government-frontend for reference, so it was still picking up the images from government-frontend. Fixed.
| display: inline-block; | ||
| margin-left: $gutter-half / 2; | ||
| margin-right: $gutter-half / 2; | ||
| margin-bottom: $gutter / 2; |
There was a problem hiding this comment.
Isn't this just $gutter-half ?
There was a problem hiding this comment.
Yeah, that's weird. Have changed.
andysellick
force-pushed
the
add-subscription-links-component
branch
from
7a294e0
to
d607586
Compare
andysellick
force-pushed
the
add-subscription-links-component
branch
from
d607586
to
ef17ad4
Compare
andysellick
force-pushed
the
add-subscription-links-component
branch
from
ef17ad4
to
91cf33e
Compare
andysellick
force-pushed
the
add-subscription-links-component
branch
from
91cf33e
to
fee41a0
Compare
andysellick
force-pushed
the
add-subscription-links-component
branch
from
fee41a0
to
639a0d9
Compare
vanitabarrett
approved these changes
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving from government-frontend to the gem. A separate PR will be raised to remove it from government-frontend. No changes to the component other than changing the CSS namespace from app-c to gem-c.
Trello cards: