Add translation nav component #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabarrett
suggested changes
May 1, 2018
| margin-bottom: $gutter; | ||
| border-bottom: 1px solid $border-colour; | ||
| @include responsive-top-margin; | ||
| @include core-16; |
There was a problem hiding this comment.
I know this is just a straight copy from government-frontend, but makes sense to tidy up while we're here - in this case, could use your suggestion of always putting @includes at the top of a CSS block
| @@ -0,0 +1,72 @@ | |||
| require "rails_helper" | |||
|
|
|||
| describe "Search", type: :view do | |||
There was a problem hiding this comment.
Is this a copy paste error?
andysellick
force-pushed
the
add-translation-nav-component
branch
from
7ab5036
to
f34540a
Compare
vanitabarrett
approved these changes
May 1, 2018
andysellick
force-pushed
the
add-translation-nav-component
branch
from
f34540a
to
5897c89
Compare
andysellick
force-pushed
the
add-translation-nav-component
branch
from
5897c89
to
cd69eec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving from government-frontend to the gem. A separate PR will be raised to remove it from government-frontend. No changes to the component other than changing the CSS namespace from app-c to gem-c.
Trello cards: