Remove translation nav component #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
changed the title
andysellick
force-pushed
the
remove-translation-nav-component
branch
from
bb80d8d
to
54c54d9
Compare
andysellick
changed the title
|
Added to govuk_publishing_components in alphagov/govuk_publishing_components#289 |
sihugh
requested changes
May 3, 2018
There was a problem hiding this comment.
I've checked the following pages locally (they have translations) and they use the component and look fine:
- a case study: https://www.gov.uk/government/case-studies/womens-rights-in-india
- world news story: https://www.gov.uk/government/news/celebrating-the-uk-india-science-and-innovation-relationship
I've checked that the things that have been removed
are those that have been added to the govuk_publishing_components gem.
If we could get the detailed guide view to use the partial as the others do, then I think we're good to go.
| @@ -4,7 +4,7 @@ | |||
| </div> | |||
| <% if @content_item.available_translations.length > 1 %> | |||
| <div class="column-third"> | |||
| <%= render 'components/translation-nav', | |||
| <%= render 'govuk_publishing_components/components/translation-nav', | |||
There was a problem hiding this comment.
If you could pull this section out and call the translations partial (below) like the other views do that'd be good.
<%= render 'shared/translations' %>
There was a problem hiding this comment.
Good spot @sihugh thanks, have updated.
andysellick
force-pushed
the
remove-translation-nav-component
branch
from
54c54d9
to
63f2008
Compare
sihugh
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The translation nav component has been moved from this app to the publishing components gem. This PR removes it and updates government-frontend to use the component from the gem.
Trello card: https://trello.com/c/ehg2nkE9/53-modify-component-translation-nav
Visual regression results:
https://government-frontend-pr-886.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-886.herokuapp.com/component-guide/translation-nav