This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
Remove performance cops #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
approved these changes
May 8, 2019
These cops are no longer available in core rubocop. rubocop/rubocop#5977
benthorner
force-pushed
the
remove-performance-cops
branch
from
ecf3892
to
a9e01f6
Compare
|
@thomasalanlee it is done :-). |
machadoit
added a commit
to codacy/codacy-rubocop
that referenced
this pull request
Jun 9, 2019
Rubocop is moving some lints to separate modules, in this case Performance - Add dependency to Gemfile - Make it part of the generate config file on the tool - Make sure you depend on them on the documentation generation, so it can fetch those patterns alphagov/govuk-lint#115
machadoit
added a commit
to codacy/codacy-rubocop
that referenced
this pull request
Jun 9, 2019
Rubocop is moving some lints to separate modules, in this case Performance (check alphagov/govuk-lint#115) - Add dependency to Gemfile - Make it part of the generate config file on the tool - Make sure you depend on them on the documentation generation, so it can fetch those patterns
machadoit
added a commit
to codacy/codacy-rubocop
that referenced
this pull request
Jun 10, 2019
Rubocop is moving some lints to separate modules, in this case Performance (check alphagov/govuk-lint#115) - Add dependency to Gemfile - Make it part of the generate config file on the tool - Make sure you depend on them on the documentation generation, so it can fetch those patterns
machadoit
added a commit
to codacy/codacy-rubocop
that referenced
this pull request
Jun 10, 2019
Rubocop is moving some lints to separate modules, in this case Performance (check alphagov/govuk-lint#115) - Add dependency to Gemfile - Make it part of the generate config file on the tool - Make sure you depend on them on the documentation generation, so it can fetch those patterns
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These cops are no longer available in core rubocop (we're getting a warning about this).
We seem to have lost a fair few cops in taking this upgrade, but looking at the comments in the issue vvv, perhaps we should avoid platform-specific linting anyway?
rubocop/rubocop#5977