Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump puppeteer from 19.3.0 to 19.4.0 #3084

Merged
merged 3 commits into from Dec 12, 2022
Merged

Bump puppeteer from 19.3.0 to 19.4.0 #3084

merged 3 commits into from Dec 12, 2022

Commits on Dec 8, 2022

  1. Bump puppeteer from 19.3.0 to 19.4.0 

    Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 19.3.0 to 19.4.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v19.3.0...puppeteer-v19.4.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot @colinrotherham
    dependabot[bot] authored and colinrotherham committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f2d3eac View commit details
    Browse the repository at this point in the history

  2. Fix race condition in Accordion accessible name test

    @colinrotherham
    colinrotherham committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    68e7715 View commit details
    Browse the repository at this point in the history

  3. Add delay for accessibility node list to be populated 

    Looks like there are some internal (to Chromium) changes when `aria-expanded` state changes, but adding a 100ms delay from Accordion button `.click()` to calling `page.accessibility.snapshot()` fixes the child node loop ✅

Lots of commits landing so may not need this workaround in future:

* chromium/chromium@08fed96
* chromium/chromium@c7fae74
* chromium/chromium@06f376b
* chromium/chromium@86543a2

Another one ongoing to stablise accessibility objects:
https://chromium-review.googlesource.com/c/chromium/src/+/4027071
    @colinrotherham
    colinrotherham committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    af91aae View commit details
    Browse the repository at this point in the history