Use native Fetch API in behaviour tests #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
added this to Needs review 🔍
in Design System Sprint Board
via automation
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3045
colinrotherham
commented
Nov 28, 2022
| @@ -18,12 +17,6 @@ const expectedPages = [ | |||
| '/examples/template-custom' | |||
| ] | |||
|
|
|||
| // Reduce test keep-alive | |||
| setGlobalDispatcher(new Agent({ | |||
| keepAliveTimeout: 10, | |||
There was a problem hiding this comment.
Unlike the undici Writing tests docs there is no keepalive default
domoscargin
approved these changes
Nov 29, 2022
| "govuk_frontend_toolkit": "^9.0.1", | ||
| "govuk_template_jinja": "^0.26.0", | ||
| "govuk-elements-sass": "3.1.3", |
There was a problem hiding this comment.
Nice little tidy up.
I would've expected govuk-elements-sass to stay where it was since hyphens come before underscores in ASCII/UTF (think it also just makes sense from a human-readable point of view - "e" comes before "f", and all that).
There was a problem hiding this comment.
@domoscargin I'll put my hand up and say I manually ordered it wrong last time (sorry), but this time it was definitely npm fixing my mistake so I've trusted it here 😬
There's an ESLint plugin for keeping package.json files in order, maybe we need it 🙈
Thanks @domoscargin
colinrotherham
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We temporarily used
undicito prepare for the Fetch API landing in Node.js 18:requestpackage with Fetch API #2858Both PRs have now merged so we can remove
undici(Another package Dependabot doesn't need to worry about)