Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing mandatory file extensions for ESM JavaScript #2658

Merged
merged 4 commits into from
Jun 20, 2022
Merged

Add missing mandatory file extensions for ESM JavaScript #2658

merged 4 commits into from
Jun 20, 2022

Commits on Jun 20, 2022

  1. Make all JavaScript files .mjs by default, and transform to .js using… 

    … rollup

Allows us to add file extensions to the end of our JavaScript imports, which means
our ESM code has "fully specified" import paths as required:

A file extension must be provided when using the import keyword to resolve relative or absolute specifiers. Directory indexes (e.g. './startup/index.js') must also be fully specified.
https://nodejs.org/api/esm.html#mandatory-file-extensions
    Vanita Barrett-Smith committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    9d4e438 View commit details
    Browse the repository at this point in the history

  2. Update documentation

    Vanita Barrett-Smith committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    80441be View commit details
    Browse the repository at this point in the history

  3. Update gulp watch task to watch .mjs files

    Vanita Barrett-Smith committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    3a05340 View commit details
    Browse the repository at this point in the history

  4. Add to changelog

    Vanita Barrett-Smith committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    b4e1dec View commit details
    Browse the repository at this point in the history