Fix race condition in Accordion accessible name test

alphagov · Dec 8, 2022 · 68e7715 · 68e7715
1 parent f2d3eac
commit 68e7715
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/lib/puppeteer-helpers.js b/lib/puppeteer-helpers.js
@@ -126,11 +126,12 @@ function getAttribute ($element, attributeName) {
 /**
  * Gets the accessible name of the given element, if it exists in the accessibility tree
  *
+ * @param {import('puppeteer').Page} page - Puppeteer page object
  * @param {import('puppeteer').ElementHandle} $element - Puppeteer element handle
  * @returns {string} The element's accessible name
  * @throws {TypeError} If the element has no corresponding node in the accessibility tree
  */
-async function getAccessibleName ($element) {
+async function getAccessibleName (page, $element) {
   // Purposefully doesn't use `?.` to return undefined if there's no node in the
   // accessibility tree. This lets us distinguish different kinds of failures:
   // - assertion on the name failing: we need to figure out

diff --git a/src/govuk/components/accordion/accordion.test.js b/src/govuk/components/accordion/accordion.test.js
@@ -251,13 +251,13 @@ describe('/components/accordion', () => {
 
           const $element = await page.$('.govuk-accordion__section-button')
 
-          expect(getAccessibleName($element)).resolves.toBe(
+          await expect(getAccessibleName(page, $element)).resolves.toBe(
             'Section A , Show this section'
           )
 
           await $element.click()
 
-          expect(getAccessibleName($element)).resolves.toBe(
+          await expect(getAccessibleName(page, $element)).resolves.toBe(
             'Section A , Hide this section'
           )
         })
@@ -269,13 +269,13 @@ describe('/components/accordion', () => {
 
           const $element = await page.$('.govuk-accordion__section-button')
 
-          expect(getAccessibleName($element)).resolves.toBe(
+          await expect(getAccessibleName(page, $element)).resolves.toBe(
             'Test , Additional description , Show this section'
           )
 
           await $element.click()
 
-          expect(getAccessibleName($element)).resolves.toBe(
+          await expect(getAccessibleName(page, $element)).resolves.toBe(
             'Test , Additional description , Hide this section'
           )
         })