Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESLint config for JavaScript Standard Style #2471

Merged
merged 5 commits into from Dec 5, 2022
Merged

Add ESLint config for JavaScript Standard Style #2471

merged 5 commits into from Dec 5, 2022

Commits on Dec 5, 2022

  1. Upgrade lint packages 

    Following the guidance in the `eslint-config-standard` README.md https://github.com/standard/eslint-config-standard#readme.
    @domoscargin
    domoscargin committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    1593e6b View commit details
    Browse the repository at this point in the history

  2. Configure standard using ESLint 

    Adds a main `.eslintrc.js` config file which extends `standard`, ignores relevant folders, and sets the test environment to jest on relevant files.

Also adds an `.eslintrc.js` file in the `src` folder, to ignore `no-var`, `object-shorthand` and `quote-props` warnings.
    @domoscargin
    domoscargin committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    57af326 View commit details
    Browse the repository at this point in the history

  3. Run eslint --fix

    @domoscargin
    domoscargin committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    cb0f281 View commit details
    Browse the repository at this point in the history

  4. Fix no-prototype-builtins error 

    This fix doesn't seem to break anything, though I'll admit it's straight off stackoverflow.
    @domoscargin
    domoscargin committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    6079eb8 View commit details
    Browse the repository at this point in the history

  5. Ignore .eslintrc.js file during build 

    The `.eslintrc.js` was being copied to `public/deploy`.
    @domoscargin
    domoscargin committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    e7525d1 View commit details
    Browse the repository at this point in the history