Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimistic govuk_publishing_components and I18n gem versions #200

Merged
merged 4 commits into from Nov 10, 2020
Merged

Optimistic govuk_publishing_components and I18n gem versions #200

merged 4 commits into from Nov 10, 2020

Commits on Nov 9, 2020

  1. Take an optimistic approach to versioning govuk_publishing_components 

    This doesn't specify a maximum version for govuk_publishing_components
which is done so that we don't have to re-release this gem each time a
new version of govuk_publishing_components is released.

As this gem only uses 2 components it seems unlikely that new versions
of govuk_publishing_components would break this gem unintentionally and,
given the frontend nature of the components, we'd likely need more than
our minitest tests to confirm compatibility for a breaking change.

If it turns out that govuk_publishing_components becomes more volatile
in it's changes we may need to switch back to pessimistic versioning but
I'm expecting this will just save people a chore moving forward.
    @kevindew
    kevindew committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    f5ce48d View commit details
    Browse the repository at this point in the history

  2. Use an optimistic I18n version 

    The I18n gem is updated infrequently and has a rather stable API. It
seems unnecessary to be using an old version (0.7) and hindering any
applications that use this gem from using a newer version.
    @kevindew
    kevindew committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    4146321 View commit details
    Browse the repository at this point in the history

  3. Loosen minitest dependency 

    We only need to care that minitest isn't a new major version so we can
loosen this pin to accept newer minor versions.
    @kevindew
    kevindew committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    9fe1b3d View commit details
    Browse the repository at this point in the history

  4. Bump to 6.5.10

    @kevindew
    kevindew committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    cf6bfff View commit details
    Browse the repository at this point in the history