Optimistic govuk_publishing_components and I18n gem versions #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't specify a maximum version for govuk_publishing_components which is done so that we don't have to re-release this gem each time a new version of govuk_publishing_components is released. As this gem only uses 2 components it seems unlikely that new versions of govuk_publishing_components would break this gem unintentionally and, given the frontend nature of the components, we'd likely need more than our minitest tests to confirm compatibility for a breaking change. If it turns out that govuk_publishing_components becomes more volatile in it's changes we may need to switch back to pessimistic versioning but I'm expecting this will just save people a chore moving forward.
The I18n gem is updated infrequently and has a rather stable API. It seems unnecessary to be using an old version (0.7) and hindering any applications that use this gem from using a newer version.
We only need to care that minitest isn't a new major version so we can loosen this pin to accept newer minor versions.
alex-ju
approved these changes
Nov 9, 2020
richardTowers
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the versioning approach we use in the gemspec for govuk_publishing_components and i18n gems. I've taken an optimistic approach where we assume future versions will work until a problem is found rather than the existing pessimistic approach where we are not allowing future versions until we've tested them.
I've done this so that we don't need to re-release this gem each time new versions of govuk_publishing_components is released as this is done very frequently (sometimes 3 minor versions in a day 馃槺 ). I expect it's an incredibly rare event that we manage to update govuk_publishing_components in a way that breaks this gem (typically for breaking component changes we identify them before releasing).
The I18n gem has a rather stable API and the current pin was tying this to a rather old version.