Skip to content

Commit

Permalink
Remove unnecessary Nokogumbo dependency
Browse files Browse the repository at this point in the history
By removing Nokogumbo we can resolve a warning that downstream apps are
emitting of "NOTE: nokogumbo: Using Nokogiri::HTML5 provided by
Nokogiri. See sparklemotion/nokogiri#2205 for
more information."
  • Loading branch information
kevindew committed Sep 30, 2021
1 parent 57e8fc9 commit d07014a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
@@ -1,5 +1,6 @@
## Unreleased

* Remove Nokogumbo dependency to [resolve warning](https://github.com/sparklemotion/nokogiri/issues/2205) [220](https://github.com/alphagov/govspeak/pull/220)
* Minimum Ruby version specified at 2.6 [215](https://github.com/alphagov/govspeak/pull/215)

## 6.7.3
Expand Down
3 changes: 1 addition & 2 deletions govspeak.gemspec
Expand Up @@ -35,8 +35,7 @@ library for use in the UK Government Single Domain project'
s.add_dependency "htmlentities", "~> 4"
s.add_dependency "i18n", ">= 0.7"
s.add_dependency "kramdown", ">= 2.3.0"
s.add_dependency "nokogiri", "~> 1.5"
s.add_dependency "nokogumbo", "~> 2"
s.add_dependency "nokogiri", "~> 1.12"
s.add_dependency "rinku", "~> 2.0"
s.add_dependency "sanitize", ">= 5.2.1", "< 6"

Expand Down
1 change: 0 additions & 1 deletion lib/govspeak.rb
Expand Up @@ -6,7 +6,6 @@
require "kramdown"
require "kramdown/parser/govuk"
require "nokogiri"
require "nokogumbo"
require "rinku"
require "sanitize"
require "govspeak/header_extractor"
Expand Down

0 comments on commit d07014a

Please sign in to comment.