Use relative URL for worldwide organisation links #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Links from the Worldwide Organisation pages currently use the `web_url`, which is absolute, and never includes the draft part of the URL. This means that a user viewing a draft Worldwide Organisation will be taken to the live version of the page. Updating to make the URL relative, meaning users are always taken to the correct version of the page. This was never previously an issue, since worldwide organisations have not previously been editionable.
brucebolt
force-pushed
the
use-relative-url
branch
from
74f4578
to
548dafd
Compare
yndajas
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links from the Worldwide Organisation pages currently use the
web_url, which is absolute, and never includes the draft part of the URL.This means that a user viewing a draft Worldwide Organisation will be taken to the live version of the page.
Updating to make the URL relative, meaning users are always taken to the correct version of the page.
This was never previously an issue, since worldwide organisations have not previously been editionable.
Trello card