Update publication pages #2302
Draft
Update publication pages #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgds
reviewed
Nov 25, 2021
chris-gds
force-pushed
the
update-publication-pages
branch
from
af29f84
to
4b21153
Compare
chris-gds
force-pushed
the
update-publication-pages
branch
from
4b21153
to
b277098
Compare
maxgds
requested changes
Nov 29, 2021
chris-gds
force-pushed
the
update-publication-pages
branch
from
5c3a7b4
to
c4c40de
Compare
chris-gds
force-pushed
the
update-publication-pages
branch
from
c4c40de
to
505ffba
Compare
chris-gds
force-pushed
the
update-publication-pages
branch
from
505ffba
to
19f23a5
Compare
chris-gds
force-pushed
the
update-publication-pages
branch
from
19f23a5
to
920bcb9
Compare
chris-gds
force-pushed
the
update-publication-pages
branch
from
920bcb9
to
3f6cce4
Compare
added 2 commits
December 1, 2021 15:47
The context_label is being defined by "schema_name: "publication" - should this be present this determines whether we class this as a "publication or consultation" Ensure title of page has "context_inside" Content prefixed to a "publication or consultation" Should content be [withdrawn] this also adds the "context_label" (or grey text) to the title scoped to items that have been identified as a "publication or consultation" Remove the loops around the attachments and just apply the context_label in all cases. Remove word "overview" from "context_inside"
No longer required
chris-gds
force-pushed
the
update-publication-pages
branch
from
3f6cce4
to
0a10ea6
Compare
maxgds
reviewed
Dec 1, 2021
| end | ||
|
|
||
| def publication_overview | ||
| overview = (I18n.exists?("content_item.#{schema_name}") == "publication" || "statistical_data_set") |
There was a problem hiding this comment.
Could you expand a little on what's going on here to help me understand? I have two questions:
- Why is statistical_data_set relevant? It's not a sub type of publication so we never expect to apply this overview/context title behaviour to it.
- Why are you looking up whether there is a translation for the schema_name ? Don't we want to always apply overview if it's a publication?
It feels like this could be as simple as line 32 - 34 being
def context_title?
content_item.#{schema_name} == "publication"
end
and lines 36-44 being removed, but I expect I'm missing something. Or multiple somethings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Apply the
context_insideoption to the title component to all publications, remove the word "overview" yet keep translations.Why
Recently some work made the 'grey text' of publication pages
h1. This provided various benefits including for screen readers and tabs. However, we only did this for pages where the title of the page and attachment are the same. For consistency this change applies to all publication pages. So that we don't have some pages that operate in one way, and others that do it differently. Also it adds benefits.Visuals
Anything else
Checked against:
http://government-frontend.dev.gov.uk/government/consultations/appraisal-periods-consultation
Add context title
Consultation outcome: Appraisal periods consultationhttp://government-frontend.dev.gov.uk/government/publications/information-superiority-jdn-213
Adds withdrawn and keep context title
[Withdrawn] Guidance: Information superiority: more than managing informationhttp://government-frontend.dev.gov.uk/government/organisations/department-of-health-and-social-care/about
No context title
About us - Department of Health and Social Carehttp://government-frontend.dev.gov.uk/government/statistical-data-sets/cw010-proportion-of-residents-walking-or-cycling-at-least-once-a-month
Adds withdrawn and no context title (as not a publication or consultation)
[Withdrawn] Proportion of residents who do any walking or cycling (at local authority level) (CW010)Related PRs
#2238
#2292