Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Imminence to PlacesManager #1253

Merged
merged 2 commits into from May 8, 2024

Conversation

georges1996
Copy link
Contributor

@georges1996 georges1996 commented May 1, 2024

This repo is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.

https://trello.com/c/V4pYtMmc/80-rename-imminence-to-places-manager-in-gds-api-adapters

@georges1996 georges1996 force-pushed the rename-Imminence-to-places-manager branch 2 times, most recently from 386fd8a to 142784c Compare May 1, 2024 14:30
@georges1996 georges1996 marked this pull request as ready for review May 2, 2024 08:23
@georges1996 georges1996 requested a review from KludgeKML May 2, 2024 08:23
lib/gds_api.rb Outdated Show resolved Hide resolved
@KludgeKML KludgeKML force-pushed the rename-Imminence-to-places-manager branch from 6143ab7 to 6071137 Compare May 8, 2024 14:28
Copy link
Contributor

@KludgeKML KludgeKML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georges1996 georges1996 merged commit cdb3bbb into main May 8, 2024
42 of 44 checks passed
@georges1996 georges1996 deleted the rename-Imminence-to-places-manager branch May 8, 2024 14:40
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants