Remove specialist topics related code from publishing-api Pact specs #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
force-pushed
the
2417-remove-specialist-topic-code-from-publishing-api-l
branch
from
a146010
to
e29e699
Compare
unoduetre
force-pushed
the
2417-remove-specialist-topic-code-from-publishing-api-l
branch
from
e29e699
to
ae58472
Compare
|
PR description is linking to old PR instead of alphagov/publishing-api#2683 |
Fixed. |
hannako
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
This looks good to me, thank you @unoduetre
Once a dev from publishing-platform approves, how will we roll this out?
If your question is about the Pact tests, there is a document I will follow: https://docs.publishing.service.gov.uk/manual/pact-testing.html#changing-existing-pact-tests |
callumknights
approved these changes
Mar 26, 2024
In publishing api pact tests. Replace topic with taxon. Update CHANGELOG.md
unoduetre
force-pushed
the
2417-remove-specialist-topic-code-from-publishing-api-l
branch
from
ae58472
to
835158d
Compare
unoduetre
deleted the
2417-remove-specialist-topic-code-from-publishing-api-l
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
What
Update publishing-api Pact specs in order to match the changes introduced in this Publishing API PR.
Why
As a dependency of this publishing-api PR.
Trello ticket
Notes
The Pact tests have been run locally from both sides in order to verify they match.