Fix duplicate page titles in places user journey #4024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line was throwing a location error when there were multiple authorities returned. This check I've added is the same as the check on line 21 to check if the multiple authorities template should be rendered (that line also checks if postcode is provided, but we already check for that on line 88 here). However, I'm not sure if my "fix" is the best way to handle this or if we should in fact investigate why the places_not_found method from the model doesn't recognise multiple authorities as a valid result. I've tried to superficially compare how this is handled for the other postcode finders like local transaction but those use the location_api model instead.
… page titles are set correctly
hannalaakso
force-pushed
the
deduplicate-places-page-titles
branch
from
724ef8f
to
bd39b1e
Compare
|
Closed in favour of #4072 which adds the fixes in this PR over the recent changes to the places directory which caused a lot of merge conflicts (I didn't replace this branch as I though it could be useful to keep it for reference for what I was originally trying to do) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Link to Trello card
How
Screenshots?