Standardise family-hub specific code #3966
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Default to not showing location data if the address or town aren't present, to allow DSA zone finder and family hub to work without bespoke code. - Report child abuse still needs specific code for message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As there are likely to be more than one dataset in imminence without physical locations, simplify to remove existing hardcoded slug for family-hub, and detect whether to show the location info based on the presense of an address and/or town (it can't be by postcode, because Imminence at the moment always requires postcodes).
Why
DSA assessment is due to change soon, to a system where contact details will not include physical addresses. Also mild reduction in tech debt.
Trello card
How
Remove hard-coding and additional partials, add checks to see whether town/address is present and hide location data.
Screenshots?
No visible changes expected to the affected path (/find-family-hub-local-area)