Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase homepage-header padding-top if menu is open #3873

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MartinJJones
Copy link
Contributor

@MartinJJones MartinJJones commented Dec 1, 2023

What

If the super navigation menu is open, set padding top to 50px for the homepage-header on Desktop screen sizes

Depends on alphagov/govuk_publishing_components#3744

Why

Trello card

Visual Changes

Before

desktop-header-before

After

desktop-header-after

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3873 December 1, 2023 17:26 Inactive
@MartinJJones MartinJJones force-pushed the increase-header-spacing-if-menu-open branch from 9911b2c to 905a818 Compare December 1, 2023 17:30
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3873 December 1, 2023 17:30 Inactive
If the super navigation menu is open, set padding top to 50px for the homepage-header on Desktop screen sizes
@MartinJJones MartinJJones force-pushed the increase-header-spacing-if-menu-open branch from 905a818 to 4e70f05 Compare December 1, 2023 17:34
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3873 December 1, 2023 17:34 Inactive
@MartinJJones MartinJJones marked this pull request as ready for review December 4, 2023 10:06
@MartinJJones MartinJJones marked this pull request as draft January 17, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants