[DO NOT MERGE] Remove metadata component #3682
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helper method is used to localize the time format - https://edgeguides.rubyonrails.org/i18n.html#adding-date-time-formats
Update the view templates for the `bank-holiday` and `when-do-the-clocks-change` to use the `metadata` component from the publishing components gem.
`last_updated` was only being used in the `metadata` app component which has been removed in favour of the `metadata` component from the publishing components gem.
MartinJJones
force-pushed
the
remove-metadata-component
branch
from
3838243
to
8c56fb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the
metadataapp component, replacing it with themetadatacomponent from the publishing components gem.Why
metadatacomponent from the publishing components gem helps to ensure that the design is consistent across GOV.UKTrello: https://trello.com/c/XZyNCfWb/56-identify-which-components-could-be-improved-rationalised-on-govuk
Visual Changes
Before
After