Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP update calendars routing #3665

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP update calendars routing #3665

wants to merge 1 commit into from

Conversation

BeckaL
Copy link
Contributor

@BeckaL BeckaL commented Jun 26, 2023

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Why

Trello card?

How

Screenshots?

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3665 June 26, 2023 10:12 Inactive
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3665 June 26, 2023 10:14 Inactive
There are three calendar paths:

* /bank-holidays
* /when-do-the-clocks-change
* /gwyliau-banc (Welsh language version of /bank-holidays)

The routing for the first two of these was previously done based on the content items (when the content item had a schema_name of calendar, it was picked up by this constraint. We are now going to publish these content items as special routes, in order to move them into special route publisher, and remove the calendar schema (since we don't publish anything substantive in the content item). This therefore updates the routing constraint to be based on these paths, rather than the schema.
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3665 June 28, 2023 14:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants