Find Local Council use shared base_page partial #3545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
changed the base branch from
main
to
error-messages-for-location-form
patrickpatrickpatrick
force-pushed
the
error-messages-for-location-form
branch
from
430b682
to
cff073c
Compare
patrickpatrickpatrick
force-pushed
the
base-page-merger
branch
from
57022a5
to
91ac8cb
Compare
patrickpatrickpatrick
changed the title
patrickpatrickpatrick
force-pushed
the
base-page-merger
branch
from
91ac8cb
to
393fa84
Compare
patrickpatrickpatrick
force-pushed
the
base-page-merger
branch
from
393fa84
to
3267d0a
Compare
A seperate base_page partial was being used for Find Local Council location form. Upon investigation, it was found that this other base page partial was not necessary and so in this commit we are removing find_local_council/base_page and using shared/find_local_council instead
The content_item generated for find_local_council tests was missing two attributes which are present in the actual content_item (title and description) for find_local_council. This was causing the tests to fail. These two extra attributes can now be added to the content_item used for tests which means they are no longer filled with random data and instead reflect the actual content_item.
patrickpatrickpatrick
force-pushed
the
base-page-merger
branch
from
444802f
to
250888f
Compare
|
@patrickpatrickpatrick is this still a thing? Can we get it reviewed? |
|
Pls attach related PRs and Trello card if so... |
|
This PR has been about for a while, going to close it for now since it's not being worked on :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the base page for Find Local Council. Find Local Council now uses the shared base_page.
Why
Found this while implementing changes to location forms on frontend. All pages on frontend use a 'base_page' partial but the Find Local Council had a different 'base_page'. It was found that the shared base_page could be used with some small changes to the find_local_council partial.