Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the alert specs to use webmock #494

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Change the alert specs to use webmock #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 15 additions & 8 deletions spec/models/email_alert_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,17 @@ def with_lock_unless_done
end

let(:logger) { double(:logger, info: nil) }
let(:alert_api) { double(:alert_api, create_content_change: nil) }
let(:email_alert) { EmailAlert.new(document, logger) }
let(:fake_lock_handler) { fake_lock_handler_class.new }

before :each do
allow(Services).to receive(:email_api_client).and_return(alert_api)
allow(LockHandler).to receive(:new).and_return(fake_lock_handler)
end

describe "#trigger" do
it "logs receiving a major change notification for a document" do
stub_create_content_change.to_return(status: 202)

email_alert.trigger

expect(logger).to have_received(:info).with(
Expand All @@ -66,16 +66,18 @@ def with_lock_unless_done
end

it "sends an alert to the Email Alert API" do
stub = stub_create_content_change
.with(body: hash_including(content_id: content_id), headers: { "GOVUK-Request-Id" => govuk_request_id })
.to_return(status: 202)

email_alert.trigger

expect(alert_api).to have_received(:create_content_change).with(
hash_including("content_id" => content_id),
govuk_request_id: govuk_request_id,
)
expect(stub).to have_been_made
end

it "logs if it receives a conflict" do
allow(alert_api).to receive(:create_content_change).and_raise(GdsApi::HTTPConflict.new(409))
stub_create_content_change.to_return(status: 409)

email_alert.trigger

expect(logger).to have_received(:info).with(
Expand All @@ -84,13 +86,18 @@ def with_lock_unless_done
end

it "logs if it receives an unprocessable entity" do
allow(alert_api).to receive(:create_content_change).and_raise(GdsApi::HTTPUnprocessableEntity.new(422))
stub_create_content_change.to_return(status: 422)

email_alert.trigger

expect(logger).to have_received(:info).with(
"email-alert-api returned unprocessable entity for #{document['content_id']}, #{document['base_path']}, #{document['public_updated_at']}",
)
end

def stub_create_content_change
stub_request(:post, "#{GdsApi::TestHelpers::EmailAlertApi::EMAIL_ALERT_API_ENDPOINT}/content-changes")
end
end

describe "#format_for_email_api" do
Expand Down
91 changes: 57 additions & 34 deletions spec/models/unpublishing_alert_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,59 +69,82 @@ def with_lock_unless_done
},
}
end
let(:alert_api) { double(:alert_api, bulk_unsubscribe: nil, find_subscriber_list: subscriber_list_response) }

before :each do
allow(LockHandler).to receive(:new).and_return(fake_lock_handler)
allow(Services).to receive(:email_api_client).and_return(alert_api)
end

describe "#trigger" do
shared_examples "a request to bulk unsubscribe with appropriate logging" do
it "logs an unsubscription notification" do
it "logs that the list does not exist and does not make a request to bulk-unsubscribe" do
stub_email_alert_api_does_not_have_subscriber_list("content_id" => content_id)

unpublishing_alert.trigger

expect(logger).to have_received(:info).with(
"Received unsubscription notification for #{document['base_path']}, unpublishing_scenario: #{unpublishing_scenario}, full payload: #{document}",
"subscriber list not found for content id #{document['content_id']}",
)
end

it "sends a bulk unsubscribe request to the Email Alert API" do
unpublishing_alert.trigger
context "when the list exists" do
before do
stub_email_alert_api_has_subscriber_list(
"content_id" => content_id,
"slug" => subscriber_list_slug,
)
end

expect(alert_api).to have_received(:bulk_unsubscribe).with(
slug: subscriber_list_slug,
govuk_request_id: govuk_request_id,
body: email_markdown.strip,
sender_message_id: sender_message_id,
)
end
it "logs an unsubscription notification" do
stub_email_alert_api_bulk_unsubscribe(slug: subscriber_list_slug)

it "logs if it recieves a conflict" do
allow(alert_api).to receive(:bulk_unsubscribe).and_raise(GdsApi::HTTPConflict.new(409))
unpublishing_alert.trigger
unpublishing_alert.trigger

expect(logger).to have_received(:info).with(
"email-alert-api returned conflict for #{document['content_id']}, #{document['base_path']}, #{document['public_updated_at']}",
)
end
expect(logger).to have_received(:info).with(
"Received unsubscription notification for #{document['base_path']}, unpublishing_scenario: #{unpublishing_scenario}, full payload: #{document}",
)
end

it "logs if it recieves an unprocessable entity" do
allow(alert_api).to receive(:bulk_unsubscribe).and_raise(GdsApi::HTTPUnprocessableEntity.new(422))
unpublishing_alert.trigger
it "sends a bulk unsubscribe request to the Email Alert API" do
stub = stub_email_alert_api_bulk_unsubscribe_with_message(
slug: subscriber_list_slug,
govuk_request_id: govuk_request_id,
body: email_markdown.strip,
sender_message_id: sender_message_id,
)

expect(logger).to have_received(:info).with(
"email-alert-api returned unprocessable entity for #{document['content_id']}, #{document['base_path']}, #{document['public_updated_at']}",
)
end
unpublishing_alert.trigger

it "logs if it recieves not found" do
allow(alert_api).to receive(:bulk_unsubscribe).and_raise(GdsApi::HTTPNotFound.new(404))
unpublishing_alert.trigger
expect(stub).to have_been_made
end

expect(logger).to have_received(:info).with(
"email-alert-api returned not_found for #{document['content_id']}, #{document['base_path']}, #{document['public_updated_at']}",
)
it "logs if it receives a conflict" do
stub_email_alert_api_bulk_unsubscribe_conflict(slug: subscriber_list_slug)

unpublishing_alert.trigger

expect(logger).to have_received(:info).with(
"email-alert-api returned conflict for #{document['content_id']}, #{document['base_path']}, #{document['public_updated_at']}",
)
end

it "logs if it receives an unprocessable entity" do
stub_email_alert_api_bulk_unsubscribe_bad_request(slug: subscriber_list_slug)

unpublishing_alert.trigger

expect(logger).to have_received(:info).with(
"email-alert-api returned unprocessable entity for #{document['content_id']}, #{document['base_path']}, #{document['public_updated_at']}",
)
end

it "logs if it receives not found" do
stub_email_alert_api_bulk_unsubscribe_not_found(slug: subscriber_list_slug)

unpublishing_alert.trigger

expect(logger).to have_received(:info).with(
"email-alert-api returned not_found for #{document['content_id']}, #{document['base_path']}, #{document['public_updated_at']}",
)
end
end
end

Expand Down